[Server] TabletServer support controlled shutdown #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
reviewed
Jun 26, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@swuferhong Thanks for the pr. Left some comments.
fluss-common/src/main/java/com/alibaba/fluss/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorServer.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/alibaba/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Show resolved
Hide resolved
...src/main/java/com/alibaba/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletServer.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
controlled-shutdown
branch
2 times, most recently
from
1b12fb9 to
b2b825b
Compare
wuchong
reviewed
Jun 29, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
As discussed offline, we need further testing on this, and guarantees the leadership transition before the server shutdown.
And I left some minor comments on the PR.
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/ServerBase.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
controlled-shutdown
branch
from
b2b825b to
3146e2d
Compare
swuferhong
force-pushed
the
controlled-shutdown
branch
2 times, most recently
from
2f06ab1 to
962777e
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
wuchong
reviewed
Sep 16, 2025
.../src/main/java/org/apache/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java
Show resolved
Hide resolved
swuferhong
force-pushed
the
controlled-shutdown
branch
from
962777e to
28db633
Compare
Contributor
Author
|
@wuchong comments addressed. |
wuchong
reviewed
Sep 19, 2025
...n/java/org/apache/fluss/server/coordinator/statemachine/ReplicaLeaderElectionAlgorithms.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fluss/server/coordinator/statemachine/TableBucketStateMachine.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
controlled-shutdown
branch
from
05073dd to
e33b510
Compare
swuferhong
force-pushed
the
controlled-shutdown
branch
from
e33b510 to
0c59730
Compare
Contributor
Author
|
@wuchong comments addressed. |
wuchong
reviewed
Sep 19, 2025
...n/java/org/apache/fluss/server/coordinator/statemachine/ReplicaLeaderElectionAlgorithms.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@wuchong LGTM |
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 21, 2025
leosanqing
pushed a commit
to leosanqing/fluss
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1142
This pr is aims to support tabletServer support controlled shutdown.
Brief change log
Tests
API and Format
Documentation