-
Notifications
You must be signed in to change notification settings - Fork 490
[spark] Add Spark show/add/drop partition support #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala
Outdated
Show resolved
Hide resolved
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala
Outdated
Show resolved
Hide resolved
bb1f92d to
0682813
Compare
|
...-common/src/main/scala/org/apache/fluss/spark/catalog/SupportsFlussPartitionManagement.scala
Show resolved
Hide resolved
| private def toInternalRow( | ||
| partitionSpec: PartitionSpec, | ||
| partitionSchema: StructType): InternalRow = { | ||
| val row = new SpecificInternalRow(partitionSchema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it here temporarily. I will move this to other place in to support batch read PR later.
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
| sql(s"INSERT INTO t values(1, 'a', 'a', 1), (2, 'b', 'a', 2), (3, 'c', 'c', 3)") | ||
|
|
||
| var expect = Seq(Row("pt1=a/pt2=1"), Row("pt1=a/pt2=2"), Row("pt1=c/pt2=3")) | ||
| checkAnswer(sql(s"SHOW PARTITIONS t"), expect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkAnswer(sql(s"SHOW PARTITIONS t"), Row("pt1=a/pt2=1") :: Row("pt1=a/pt2=2") :: Row("pt1=c/pt2=3") :: Nil)
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Show resolved
Hide resolved
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Show resolved
Hide resolved
0682813 to
968af43
Compare
|
LGTM. |
|
kindly ping @wuchong |
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Yohahaha , @YannByron , LGTM
Purpose
As title.
Linked issue: close #xxx
Brief change log
Tests
org.apache.fluss.spark.SparkCatalogTest
API and Format
Documentation