[server] UpdateMetadata RPC should update tablePath and physicalTablePath cache #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
upgrade-server-cache
branch
5 times, most recently
from
3691681 to
be96873
Compare
2 tasks
swuferhong
force-pushed
the
upgrade-server-cache
branch
from
be96873 to
129214a
Compare
Contributor
Author
|
@wuchong @loserwang1024 @luoyuxia pr ready. Could you pls take a look? thx. |
swuferhong
force-pushed
the
upgrade-server-cache
branch
4 times, most recently
from
720c486 to
7662e6e
Compare
luoyuxia
reviewed
May 22, 2025
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorEventProcessor.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorRequestBatch.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorRequestBatch.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorRequestBatch.java
Show resolved
Hide resolved
...s-server/src/main/java/com/alibaba/fluss/server/metadata/CoordinatorServerMetadataCache.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
upgrade-server-cache
branch
4 times, most recently
from
3edf628 to
7e791ac
Compare
wuchong
reviewed
Jun 2, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @swuferhong , I left some comments. And please fix the failed cases.
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Outdated
Show resolved
Hide resolved
...test/java/com/alibaba/fluss/server/coordinator/statemachine/TableBucketStateMachineTest.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/coordinator/TableManagerITCase.java
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/metadata/Schema.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/metadata/TabletServerMetadataCache.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/metadata/TabletServerMetadataCache.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorRequestBatch.java
Show resolved
Hide resolved
...s-server/src/main/java/com/alibaba/fluss/server/metadata/CoordinatorServerMetadataCache.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
upgrade-server-cache
branch
3 times, most recently
from
ca922c0 to
8c59340
Compare
swuferhong
force-pushed
the
upgrade-server-cache
branch
from
8c59340 to
252fe12
Compare
Contributor
Author
|
@wuchong comments addressed, pr ready. |
wuchong
reviewed
Jun 3, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Looks good in general. I left some minor comments.
fluss-server/src/main/java/com/alibaba/fluss/server/metadata/BucketMetadata.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorRequestBatch.java
Outdated
Show resolved
Hide resolved
...s-server/src/main/java/com/alibaba/fluss/server/metadata/CoordinatorServerMetadataCache.java
Outdated
Show resolved
Hide resolved
...server/src/test/java/com/alibaba/fluss/server/replica/RemoveOfflineReplicaFromIsrITCase.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/RpcServiceBase.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/utils/ServerRpcMessageUtils.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/utils/ServerRpcMessageUtils.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@wuchong comments addressed. |
zcoo
pushed a commit
to zcoo/fluss
that referenced
this pull request
Jun 4, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Jun 6, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Jun 6, 2025
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #757
Currently, UpdateMetadata RPC only updates coordinator and tablet server informations in the cluster, but we should also update table path information in the cluster. This has already added in the RPC protocol, but didn't implement in Coordinator side and TabletServer side. So this pr is aims to make
UpdateMetadata RPCupdate tablePath and physicalTablePath of ServerMetadata cache.Brief change log
Tests
API and Format
Documentation