Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Optimize object array copy performance #1749

Closed
chaokunyang opened this issue Jul 21, 2024 · 0 comments · Fixed by #1770
Closed

[Java] Optimize object array copy performance #1749

chaokunyang opened this issue Jul 21, 2024 · 0 comments · Fixed by #1770
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chaokunyang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Object array elements are homogeneous mostly, we can cache the previoues immutable info and reduce type dispatch cost to speed up performance.

Describe the solution you'd like

Additional context

#1679
#1743
@chaokunyang chaokunyang added enhancement New feature or request good first issue Good for newcomers labels Jul 21, 2024
@chaokunyang chaokunyang mentioned this issue Jul 27, 2024
Merged
2 tasks
chaokunyang added a commit that referenced this issue Jul 27, 2024
@chaokunyang
perf(java): optimize object array copy perf (#1770)
f4865f0 
## What does this PR do?

optimize object array copy perf

## Related issues

Closes #1749


## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?


## Benchmark

```
Benchmark                             (bufferType)  (references)   Mode  Cnt        Score         Error  Units
CopyBenchmark.fury_copy_object_array         array         false  thrpt    3  3738130.731 ± 2558439.249  ops/s
CopyBenchmark.kryo_copy_object_array         array         false  thrpt    3  1840856.001 ± 3577628.201  ops/s

Benchmark                             (bufferType)  (references)   Mode  Cnt        Score         Error  Units
CopyBenchmark.fury_copy_object_array         array         false  thrpt    3  8025674.789 ± 7659990.718  ops/s
CopyBenchmark.kryo_copy_object_array         array         false  thrpt    3  1167037.754 ± 1372076.679  ops/s
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(java): optimize object array copy perf chaokunyang/fury
1 participant
@chaokunyang