Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Windows build support #798

Open
chaokunyang opened this issue Jul 30, 2023 · 3 comments · May be fixed by #1885
Open

[C++] Windows build support #798

chaokunyang opened this issue Jul 30, 2023 · 3 comments · May be fixed by #1885
Labels
c++ enhancement New feature or request good first issue Good for newcomers python

Comments

@chaokunyang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Fury support macos and linux build, but windows is not supported.

Fury use bazel for building c++ code, windows building need some extra work.
@chaokunyang chaokunyang added enhancement New feature or request python c++ labels Jul 30, 2023
@chaokunyang chaokunyang changed the title [Python] Windows build support [C++] Windows build support Jul 30, 2023
@chaokunyang chaokunyang added the good first issue Good for newcomers label Nov 2, 2023
@LiangliangSui
Copy link
Contributor

Can I try to do some work on this? @chaokunyang

@chaokunyang
Copy link
Collaborator Author

Can I try to do some work on this? @chaokunyang

Of course. Welcome to try this issue. Thanks for the willingness to contribute to Fury.

@chaokunyang
Copy link
Collaborator Author

I haven't try bazel on Windows. If you want to try this issue, you may need to install bazel on Windows first, and fix some compilation issues.

@An-DJ An-DJ mentioned this issue Oct 7, 2024
Merged
2 tasks
chaokunyang pushed a commit that referenced this issue Oct 9, 2024
@An-DJ
feat(bazel): support building C++ libs on windows platform (#1873)
0e20458 
<!--
**Thanks for contributing to Fury.**

**If this is your first time opening a PR on fury, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fury (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).

- Fury has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?

Make bazel happy on `Windows OS`.

1. Rewrite a little codes in `row.cc`, then it could be compiled by MSVC
([VLA is not
supported](https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/))
2. Add MSVC flag
[`/Zc:preprocessor`](https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170)
to enable C99/C11
3. Add MSVC flag
[`/utf-8`](https://learn.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-170)
to set source and execution character sets to UTF-8.
4. Load arrow(arrow_python) interface libraries `*.lib` to the linker
5. Add a new CI env `windows-2022` to build fury cpp libraries

<!-- Describe the purpose of this PR. -->

## Related issues

#798 

<!--
Is there any related issue? Please attach here.

- #xxxx0
- #xxxx1
- #xxxx2
-->

## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fury/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->

---------

Signed-off-by: Junduo Dong <andj4cn@gmail.com>
@An-DJ An-DJ linked a pull request Nov 2, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ enhancement New feature or request good first issue Good for newcomers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): support building python on windows An-DJ/fury
2 participants
@chaokunyang @LiangliangSui