Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): extract public Fury methods to BaseFury #1467

Merged
merged 3 commits into from
Apr 6, 2024

Conversation

Munoon
Copy link
Contributor

@Munoon Munoon commented Apr 4, 2024

Extract public Fury method to the BaseFury interface and implement them in ThreadPoolFury and ThreadLocalFury, so end users can avoid using execute() and other utility methods.

Off topic: further steps might be changing BaseFury interface name to Fury while existing class renaming to something like FuryImpl. FuryBuilder should return the new Fury interface, so we will hide system methods like xwriteRef and others. WDYT?

@Munoon Munoon requested a review from chaokunyang as a code owner April 4, 2024 19:52
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit ca996d4 into apache:main Apr 6, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants