Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): support deserialize unexisted array/enum classes #1569

Merged

Conversation

chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Apr 24, 2024

What does this PR do?

This PR support sdeserialize unexisted array/enum object.

For type compatible serialization, deserialization process may not have the class in serialization peer. In such cases, we should support skip object data of unexisted array/enum

Related issues

Closes #1564

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@chaokunyang
Copy link
Collaborator Author

chaokunyang commented Apr 25, 2024

Hi @theweipeng @LiangliangSui , could you take a look at this PR?
I plan include it in v0.5.0 release

Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang
Copy link
Collaborator Author

Hi @LiangliangSui , I've addressed all your comments, could you take a look at it again?

@chaokunyang chaokunyang merged commit d59c57c into apache:main Apr 26, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants