feat(kotlin): Add unsigned array support and tests for arrays and strings #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wywen
changed the title
chaokunyang
reviewed
Oct 18, 2024
| } | ||
|
|
||
| override fun write(buffer: MemoryBuffer, value: T) { | ||
| val delegatingSerializer = fury.classResolver.getSerializer(delegateClass) |
There was a problem hiding this comment.
Could we make this as a field of the DelegatingArraySerializer to reduce lookup cost?
There was a problem hiding this comment.
I guess all those unsiged array type are final
There was a problem hiding this comment.
Yup those arrays are final! I made it a lazily initialized field.
There was a problem hiding this comment.
The lazy can be removed too
chaokunyang
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds tests for serializing/deserializing:
UByteArray,UIntArray,UShortArray,ULongArrayUnsigned arrays in kotlin are currently marked experimental, and are subject to API changes (hence the annotations needed to suppress those warnings).
These types are implemented as a view over the signed arrays e.g. UByteArray is a view over ByteArray with contents reinterpreted as UByte, so serializers. The current implementation delegate to existing serializers for corresponding signed types.
The xlang type id is set to LIST for unsigned types.
Related issues
#683
Does this PR introduce any user-facing change?
Yes. Unsigned primitives no longer need to be registered for
fury-kotlin.Benchmark
N/A