grails/gorm-mongodb#77 Updated MultiTenantEventListener #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntId filter Updated MultiTenantEventListener to not add multi-tenant filter to the query in case of shared database and when `tenantId` is DEFAULT
puneetbehl
commented
May 6, 2019
| @@ -55,12 +55,13 @@ class MultiTenantEventListener implements PersistenceEventListener { | |||
| TenantId tenantId = entity.getTenantId(); | |||
| if(tenantId != null) { | |||
| Serializable currentId = Tenants.currentId(datastoreClient.getClass()); | |||
| query.eq(tenantId.getName(), currentId ); | |||
| if (currentId != ConnectionSource.DEFAULT) { | |||
There was a problem hiding this comment.
@graemerocher The reason I decided to add this check here is that in case of non shared multi-tenant database (e.g. multi-tenancy across databases) we might be using that default data source in case tenantId is not specified and we do not know in Tenants.groovy that if it's a shared or nonshared multi-tenancy. However, I am not sure about the above logic so please suggest if we need to fix this some other way.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MultiTenantEventListener to not add the multi-tenant filter to the query in case of shared database and when
tenantIdis DEFAULT