[#676] feat(jdbc): Support jdbc operations in JDBC catalog.

apache · Nov 17, 2023 · 087e191 · 087e191
1 parent b645cf9
commit 087e191
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...mmon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/DatabaseOperation.java b/...mmon/src/main/java/com/datastrato/gravitino/catalog/jdbc/operation/DatabaseOperation.java
@@ -34,7 +34,7 @@ void initialize(final DataSource dataSource, final JdbcExceptionConverter except
 
   /**
    * @param databaseName The name of the database to check.
-   * @param cascade If set to true, drops all the tables in the schema as well.
+   * @param cascade If set to true, drops all the tables in the database as well.
    */
   void delete(String databaseName, boolean cascade);
 

diff --git a/...dbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/utils/DataSourceUtils.java b/...dbc-common/src/main/java/com/datastrato/gravitino/catalog/jdbc/utils/DataSourceUtils.java
@@ -6,12 +6,13 @@
 
 import com.datastrato.gravitino.catalog.jdbc.config.JdbcConfig;
 import com.datastrato.gravitino.exceptions.GravitinoRuntimeException;
+import org.apache.commons.dbcp2.BasicDataSource;
+import org.apache.commons.dbcp2.BasicDataSourceFactory;
+
+import javax.sql.DataSource;
 import java.sql.SQLException;
 import java.util.Map;
 import java.util.Properties;
-import javax.sql.DataSource;
-import org.apache.commons.dbcp2.BasicDataSource;
-import org.apache.commons.dbcp2.BasicDataSourceFactory;
 
 /**
  * Utility class for creating a {@link DataSource} from a {@link JdbcConfig}. It is mainly
@@ -68,7 +69,7 @@ public static void closeDataSource(DataSource dataSource) {
         assert dataSource instanceof BasicDataSource;
         ((BasicDataSource) dataSource).close();
       } catch (SQLException ignore) {
-
+        // no op
       }
     }
   }