-
Notifications
You must be signed in to change notification settings - Fork 392
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### What changes were proposed in this pull request? Add basic role commands to Gravitino CLI ### Why are the changes needed? For the CLI to support roles. Fix: #5162 ### Does this PR introduce _any_ user-facing change? No, but it adds roles to the CLI. ### How was this patch tested? Compiled and tested locally.
- Loading branch information
1 parent
3ccd89a
commit eba65cd
Showing
10 changed files
with
359 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateRole.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.cli.commands; | ||
|
|
||
| import java.util.Collections; | ||
| import org.apache.gravitino.cli.ErrorMessages; | ||
| import org.apache.gravitino.client.GravitinoClient; | ||
| import org.apache.gravitino.exceptions.NoSuchMetalakeException; | ||
| import org.apache.gravitino.exceptions.RoleAlreadyExistsException; | ||
|
|
||
| public class CreateRole extends Command { | ||
| protected String metalake; | ||
| protected String role; | ||
|
|
||
| /** | ||
| * Create a new role. | ||
| * | ||
| * @param url The URL of the Gravitino server. | ||
| * @param ignoreVersions If true don't check the client/server versions match. | ||
| * @param metalake The name of the metalake. | ||
| * @param role The name of the role. | ||
| */ | ||
| public CreateRole(String url, boolean ignoreVersions, String metalake, String role) { | ||
| super(url, ignoreVersions); | ||
| this.metalake = metalake; | ||
| this.role = role; | ||
| } | ||
|
|
||
| /** Create a new role. */ | ||
| @Override | ||
| public void handle() { | ||
| try { | ||
| GravitinoClient client = buildClient(metalake); | ||
| client.createRole(role, null, Collections.EMPTY_LIST); | ||
| } catch (NoSuchMetalakeException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_METALAKE); | ||
| return; | ||
| } catch (RoleAlreadyExistsException err) { | ||
| System.err.println(ErrorMessages.ROLE_EXISTS); | ||
| return; | ||
| } catch (Exception exp) { | ||
| System.err.println(exp.getMessage()); | ||
| return; | ||
| } | ||
|
|
||
| System.out.println(role + " created"); | ||
| } | ||
| } |
80 changes: 80 additions & 0 deletions
80
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteRole.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.cli.commands; | ||
|
|
||
| import org.apache.gravitino.cli.AreYouSure; | ||
| import org.apache.gravitino.cli.ErrorMessages; | ||
| import org.apache.gravitino.client.GravitinoClient; | ||
| import org.apache.gravitino.exceptions.NoSuchMetalakeException; | ||
| import org.apache.gravitino.exceptions.NoSuchRoleException; | ||
|
|
||
| public class DeleteRole extends Command { | ||
|
|
||
| protected String metalake; | ||
| protected String role; | ||
| protected boolean force; | ||
|
|
||
| /** | ||
| * Delete a role. | ||
| * | ||
| * @param url The URL of the Gravitino server. | ||
| * @param ignoreVersions If true don't check the client/server versions match. | ||
| * @param force Force operation. | ||
| * @param metalake The name of the metalake. | ||
| * @param role The name of the role. | ||
| */ | ||
| public DeleteRole( | ||
| String url, boolean ignoreVersions, boolean force, String metalake, String role) { | ||
| super(url, ignoreVersions); | ||
| this.metalake = metalake; | ||
| this.force = force; | ||
| this.role = role; | ||
| } | ||
|
|
||
| /** Delete a role. */ | ||
| @Override | ||
| public void handle() { | ||
| boolean deleted = false; | ||
|
|
||
| if (!AreYouSure.really(force)) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| GravitinoClient client = buildClient(metalake); | ||
| deleted = client.deleteRole(role); | ||
| } catch (NoSuchMetalakeException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_METALAKE); | ||
| return; | ||
| } catch (NoSuchRoleException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_ROLE); | ||
| return; | ||
| } catch (Exception exp) { | ||
| System.err.println(exp.getMessage()); | ||
| return; | ||
| } | ||
|
|
||
| if (deleted) { | ||
| System.out.println(role + " deleted."); | ||
| } else { | ||
| System.out.println(role + " not deleted."); | ||
| } | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListRoles.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.cli.commands; | ||
|
|
||
| import org.apache.gravitino.cli.ErrorMessages; | ||
| import org.apache.gravitino.client.GravitinoClient; | ||
| import org.apache.gravitino.exceptions.NoSuchMetalakeException; | ||
|
|
||
| /* Lists all roles in a metalake. */ | ||
| public class ListRoles extends Command { | ||
|
|
||
| protected String metalake; | ||
|
|
||
| /** | ||
| * Lists all groups in a metalake. | ||
| * | ||
| * @param url The URL of the Gravitino server. | ||
| * @param ignoreVersions If true don't check the client/server versions match. | ||
| * @param metalake The name of the metalake. | ||
| */ | ||
| public ListRoles(String url, boolean ignoreVersions, String metalake) { | ||
| super(url, ignoreVersions); | ||
| this.metalake = metalake; | ||
| } | ||
|
|
||
| /** Lists all roles in a metalake. */ | ||
| @Override | ||
| public void handle() { | ||
| String[] roles = new String[0]; | ||
| try { | ||
| GravitinoClient client = buildClient(metalake); | ||
| roles = client.listRoleNames(); | ||
| } catch (NoSuchMetalakeException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_METALAKE); | ||
| return; | ||
| } catch (Exception exp) { | ||
| System.err.println(exp.getMessage()); | ||
| return; | ||
| } | ||
|
|
||
| String all = String.join(",", roles); | ||
|
|
||
| System.out.println(all.toString()); | ||
| } | ||
| } |
73 changes: 73 additions & 0 deletions
73
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RoleDetails.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.cli.commands; | ||
|
|
||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import org.apache.gravitino.authorization.SecurableObject; | ||
| import org.apache.gravitino.cli.ErrorMessages; | ||
| import org.apache.gravitino.client.GravitinoClient; | ||
| import org.apache.gravitino.exceptions.NoSuchMetalakeException; | ||
| import org.apache.gravitino.exceptions.NoSuchUserException; | ||
|
|
||
| public class RoleDetails extends Command { | ||
|
|
||
| protected String metalake; | ||
| protected String role; | ||
|
|
||
| /** | ||
| * Displays the securable objects in a role. | ||
| * | ||
| * @param url The URL of the Gravitino server. | ||
| * @param ignoreVersions If true don't check the client/server versions match. | ||
| * @param metalake The name of the metalake. | ||
| * @param role The name of the role. | ||
| */ | ||
| public RoleDetails(String url, boolean ignoreVersions, String metalake, String role) { | ||
| super(url, ignoreVersions); | ||
| this.metalake = metalake; | ||
| this.role = role; | ||
| } | ||
|
|
||
| /** Displays the securable objects of a specified role. */ | ||
| @Override | ||
| public void handle() { | ||
| List<SecurableObject> objects = null; | ||
|
|
||
| try { | ||
| GravitinoClient client = buildClient(metalake); | ||
| objects = client.getRole(role).securableObjects(); | ||
| } catch (NoSuchMetalakeException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_METALAKE); | ||
| return; | ||
| } catch (NoSuchUserException err) { | ||
| System.err.println(ErrorMessages.UNKNOWN_GROUP); | ||
| return; | ||
| } catch (Exception exp) { | ||
| System.err.println(exp.getMessage()); | ||
| return; | ||
| } | ||
|
|
||
| // TODO expand in securable objects PR | ||
| String all = objects.stream().map(SecurableObject::name).collect(Collectors.joining(",")); | ||
|
|
||
| System.out.println(all.toString()); | ||
| } | ||
| } |
Oops, something went wrong.