Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] Add user doc for column default value #1590

Closed
Tracked by #896
mchades opened this issue Jan 18, 2024 · 6 comments · Fixed by #2003
Closed
Tracked by #896

[Subtask] Add user doc for column default value #1590

mchades opened this issue Jan 18, 2024 · 6 comments · Fixed by #2003
Assignees

Comments

@mchades
Copy link
Contributor

mchades commented Jan 18, 2024

Describe the subtask

Add user doc for column default value

Parent issue

#896

@hiirrxnn
Copy link
Contributor

Please tell me precisely what is to be done here and I will get started on it .

@mchades
Copy link
Contributor Author

mchades commented Jan 22, 2024

Please tell me precisely what is to be done here and I will get started on it .

Thank you for volunteering!

The document with column default value depends on the expression document, because the default values of the column are represented by the expression. Would you like to document the expression first?

@hiirrxnn
Copy link
Contributor

Could you please guide me on how to document the expression ?

@mchades
Copy link
Contributor Author

mchades commented Jan 22, 2024

Of course!
But this may require some prior knowledge. Are you familiar with Gravitino Expression or SQL Expression? If you are already familiar with those, we need a document named gravitino-expression-system.md. In this document, present the definition, implementation, and invocation method of the com.datastrato.gravitino.rel.expressions.Expression interface from the user's perspective. Provide corresponding REST and Java use cases, as well as equivalent SQL semantics. Finally, add a document link to any mentions of Expression in other documents.

I understand that this may be challenging for non-interface developers. If you feel the same way, I still have more accessible issues to choose from, such as #1640

@hiirrxnn
Copy link
Contributor

Since I have no prior experience in Gravitino/SQL expression , I feel I am better suited for #1640 . Also , please let me know which topics/tech-stacks to be studied so I can solve a problem like this one , in the future.

@mchades
Copy link
Contributor Author

mchades commented Jan 23, 2024

Since I have no prior experience in Gravitino/SQL expression , I feel I am better suited for #1640 . Also , please let me know which topics/tech-stacks to be studied so I can solve a problem like this one , in the future.

Any one of the Gravitino catalog engines is good for study, such as Iceberg, Hive, MySQL, PostgreSQL

jerryshao pushed a commit that referenced this issue Feb 4, 2024
### What changes were proposed in this pull request?

Add doc for column default value

### Why are the changes needed?

Fix: #1590 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

no need
github-actions bot pushed a commit that referenced this issue Feb 4, 2024
### What changes were proposed in this pull request?

Add doc for column default value

### Why are the changes needed?

Fix: #1590 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

no need
jerryshao added a commit that referenced this issue Feb 5, 2024
### What changes were proposed in this pull request?

Add doc for column default value

### Why are the changes needed?

Fix: #1590 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

no need

Co-authored-by: mchades <liminghuang@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants