Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Unify style of the configuration options #2042

Closed
qqqttt123 opened this issue Feb 4, 2024 · 0 comments · Fixed by #2043
Closed

[Improvement] Unify style of the configuration options #2042

qqqttt123 opened this issue Feb 4, 2024 · 0 comments · Fixed by #2043
Labels
improvement Improvements on everything
Milestone
Gravitino 0.4.0

Comments

@qqqttt123
Copy link
Contributor

What would you like to be improved?

In the configuration of security example , we use instead of =. But other places use =. So it's better to unify them.

How should we improve?

No response
@qqqttt123 qqqttt123 added the improvement Improvements on everything label Feb 4, 2024
qqqttt123 pushed a commit to qqqttt123/gravitino that referenced this issue Feb 4, 2024
[apache#2042] improvement(doc): Unify the style of configuration options
1c94e24
@qqqttt123 qqqttt123 mentioned this issue Feb 4, 2024
Merged
jerryshao pushed a commit that referenced this issue Feb 4, 2024
@qqqttt123
[#2042] improvement(doc): Unify the style of configuration options (#…
a9dd794 
…2043)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Unify the style of configuration options

### Why are the changes needed?

Fix: #2042 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Just doc.

Co-authored-by: Heng Qin <qqtt@123.com>
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Feb 4, 2024
github-actions bot pushed a commit that referenced this issue Feb 4, 2024
@qqqttt123 @web-flow
[#2042] improvement(doc): Unify the style of configuration options (#…
70f949f 
…2043)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Unify the style of configuration options

### Why are the changes needed?

Fix: #2042 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Just doc.

Co-authored-by: Heng Qin <qqtt@123.com>
@jerryshao jerryshao mentioned this issue Feb 4, 2024
Merged
qqqttt123 added a commit that referenced this issue Feb 4, 2024
@jerryshao @qqqttt123
[#2042] improvement(doc): Unify the style of configuration options (#…
c1c4b89 
…2045)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Unify the style of configuration options

### Why are the changes needed?

Fix: #2042 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Just doc.

Co-authored-by: qqqttt123 <148952220+qqqttt123@users.noreply.github.com>
Co-authored-by: Heng Qin <qqtt@123.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.4.0
Development

Successfully merging a pull request may close this issue.

[#2042] improvement(doc): Unify the style of configuration options qqqttt123/gravitino
2 participants
@jerryshao @qqqttt123