Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove directory spark-warehouse when exectue gradle clean in moudle catalog-lakehouse-iceberg #2508

Closed
yuqi1129 opened this issue Mar 11, 2024 · 2 comments · Fixed by #2531
Closed

[Improvement] Remove directory spark-warehouse when exectue gradle clean in moudle catalog-lakehouse-iceberg #2508

yuqi1129 opened this issue Mar 11, 2024 · 2 comments · Fixed by #2531
Assignees
@yijhenlin
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 11, 2024 •
edited
Loading

What would you like to be improved?

spark-warehouse is a temporary directory produced by the test, we need to remove it when do the clean task.

image

You can generate spark-warehouse by gradle :catalogs:catalog-lakehouse-iceberg:test

How should we improve?

No response
@yuqi1129 yuqi1129 added improvement Improvements on everything good first issue Good for newcomers labels Mar 11, 2024
@yijhenlin
Copy link
Contributor

Hi, I would like to solve this issue.

@yijhenlin yijhenlin mentioned this issue Mar 14, 2024
Merged
@yijhenlin
Copy link
Contributor

Hi, there leave another empty directory server/src/main/resources/ after execute gradle clean.
should I remove it too?

$ git clean -d -n
Would remove server/src/main/resources/

yuqi1129 added a commit that referenced this issue Mar 14, 2024
@yijhenlin @yuqi1129
[#2508] improvement: Remove untracked directories when executing grad…
e65ba06 
…le clean (#2531)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Remove directory `spark-warehouse` when exectue gradle clean in moudle
catalog-lakehouse-iceberg.
Remove directory `src/main/resources` when execute gradle clean in
module server, since which is generated by gradle build.

### Why are the changes needed?

Fix: #2508

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

`./gradlew :catalogs:catalog-lakehouse-iceberg:clean`
`./gradlew :server:clean`

---------

Co-authored-by: Qi Yu <yuqi@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yijhenlin yijhenlin

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2508] improvement: Remove untracked directories when executing gradle clean yijhenlin/gravitino
2 participants
@yuqi1129 @yijhenlin