Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Merging embedded and deploy test mode for frontend integration test #2798

Closed
xunliu opened this issue Apr 4, 2024 · 0 comments · Fixed by #2817
Closed

[Improvement] Merging embedded and deploy test mode for frontend integration test #2798

xunliu opened this issue Apr 4, 2024 · 0 comments · Fixed by #2817
Assignees
@ch3yne
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@xunliu
Copy link
Member

xunliu commented Apr 4, 2024

What would you like to be improved?

Use two Github Action to test frontend integration test is very occupancy time,
So we can Merging embedded and deploy test mode in one Github Action.

How should we improve?

Delete these code from .github/workflows/frontend-integration-test.yml

        test-mode: [ embedded, deploy ]

And modify tese code in .github/workflows/frontend-integration-test.yml

      - name: Frontend Integration Test
        id: integrationTest
        run: |
          ./gradlew --rerun-tasks -PskipTests -PtestMode=embedded -PjdkVersion=${{ matrix.java-version }} :integration-test:test --tests "com.datastrato.gravitino.integration.test.web.ui.**"
          ./gradlew --rerun-tasks -PskipTests -PtestMode=deploy -PjdkVersion=${{ matrix.java-version }} :integration-test:test --tests "com.datastrato.gravitino.integration.test.web.ui.**"

But note, if you create database or table in frontend integration test case and forget deleted it, maybe these test case will failed in the next test mode.
@xunliu xunliu added the improvement Improvements on everything label Apr 4, 2024
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 7, 2024
@ch3yne ch3yne mentioned this issue Apr 7, 2024
Merged
jerryshao pushed a commit that referenced this issue Apr 8, 2024
@ch3yne
[#2798] improve(CI): Modified CI configuration for frontend integrati…
bb719e1 
…on test (#2817)

### What changes were proposed in this pull request?

Merging embedded and deploy test mode for frontend integration test, and
just test with Java 8 version.

### Why are the changes needed?

Fix: #2798

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2798] improve(CI): Modified CI configuration for frontend integration test ch3yne/gravitino
3 participants
@jerryshao @xunliu @ch3yne