Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] All data disappear after refresh if error happens in the web page #2996

Closed
yuqi1129 opened this issue Apr 17, 2024 · 0 comments · Fixed by #3014
Closed

[Bug report] All data disappear after refresh if error happens in the web page #2996

yuqi1129 opened this issue Apr 17, 2024 · 0 comments · Fixed by #3014
Assignees
@LauraXia123 @ch3yne
Labels
bug Something isn't working
Milestone
Gravitino 0.5.0

Comments

@yuqi1129
Copy link
Contributor

Version

main branch

Describe what's wrong

2024-04-17.17.43.18.mov

Error message and/or stacktrace

Please see above.

How to reproduce

please see above

Additional context

No response
@yuqi1129 yuqi1129 added the bug Something isn't working label Apr 17, 2024
@yuqi1129 yuqi1129 added this to the Gravitino 0.5.0 milestone Apr 17, 2024
@ch3yne ch3yne self-assigned this Apr 18, 2024
LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue Apr 18, 2024
@LauraXia123
[apache#2996][apache#3011] fix refresh issue and kafka topic property…
a403713 
… issue
@LauraXia123 LauraXia123 mentioned this issue Apr 18, 2024
Merged
ch3yne pushed a commit that referenced this issue Apr 19, 2024
@LauraXia123
[#2996][#3011] fix(web): fix refresh issue and kafka topic property i…
6c8b3c4 
…ssue (#3014)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Load catalogs first when refresh schema or table level page
<img width="1395" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f3af84e6-d6dc-474e-9f55-e714edb9be35">
Fix kafka topic property issue

### Why are the changes needed?

Fix: #2996, Fix: #3011

### Does this PR introduce _any_ user-facing change?
When schema, table or fileset page network error, refresh the page

### How was this patch tested?
<img width="735" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d69bc9f3-d4f7-4f1e-bc2c-65941821a510">
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@LauraXia123 @diqiu50
[apache#2996][apache#3011] fix(web): fix refresh issue and kafka topi…
75616d0 
…c property issue (apache#3014)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Load catalogs first when refresh schema or table level page
<img width="1395" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/f3af84e6-d6dc-474e-9f55-e714edb9be35">
Fix kafka topic property issue

### Why are the changes needed?

Fix: apache#2996, Fix: apache#3011

### Does this PR introduce _any_ user-facing change?
When schema, table or fileset page network error, refresh the page

### How was this patch tested?
<img width="735" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d69bc9f3-d4f7-4f1e-bc2c-65941821a510">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

@ch3yne ch3yne

Labels
bug Something isn't working
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2996][#3011] fix(web): fix refresh issue and kafka topic property issue LauraXia123/gravitino
3 participants
@LauraXia123 @yuqi1129 @ch3yne