Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] UI: Index is not shown very clearly #3058

Closed
yuqi1129 opened this issue Apr 20, 2024 · 0 comments · Fixed by #3102
Closed

[Improvement] UI: Index is not shown very clearly #3058

yuqi1129 opened this issue Apr 20, 2024 · 0 comments · Fixed by #3102
Assignees
@ch3yne
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

image

We should use ',' NOT '.' to support multiple columns in a index.

How should we improve?

We should use ',' NOT '.' to support multiple columns in a index.
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Apr 20, 2024
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Apr 22, 2024
@ch3yne ch3yne mentioned this issue Apr 22, 2024
Merged
LauraXia123 pushed a commit that referenced this issue Apr 22, 2024
@ch3yne
[#3058] fix(web): fix value displaying and enhance the styles (#3102)
841c902 
### What changes were proposed in this pull request?

Fix value displaying and enhance the styles.

### Why are the changes needed?

Fix: #3058

### Does this PR introduce _any_ user-facing change?

`[['id', 'b'], ['name'], ['d', 'e'], ['f'], ['g']]`

header:
<img width="129" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/5206bd0c-a3d6-487c-a623-52d91b2429cf">
column:
<img width="219" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/da060e00-a472-4df5-98f7-8b4feda51ea8">


others:

<img width="157" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/364ff92d-8472-4c5e-ace0-30e709f84c5c">

<img width="196" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/a0dc67f4-1b2f-4481-945c-b0bc773e0735">

<img width="148" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/02463cf3-8e7c-40c5-a73a-a2dbea8392ce">

<img width="182" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/e9578950-7686-4b70-9216-14b987d88181">

<img width="175" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/eb62d830-d6a5-4eea-817b-adaded5c04ae">

<img width="217" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/933a4554-3e5f-4b04-b04f-2d0e84e4a734">


### How was this patch tested?

local
jerryshao pushed a commit that referenced this issue May 23, 2024
@noidname01
[#3058] improvement(client-python): Correct type specification of cre…
ee6b9db 
…ate_fileset function (#3509)

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: #3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: TimWang <tim.wang@pranaq.com>
github-actions bot pushed a commit that referenced this issue May 23, 2024
@noidname01 @web-flow
[#3058] improvement(client-python): Correct type specification of cre…
d054b61 
…ate_fileset function (#3509)

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: #3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: TimWang <tim.wang@pranaq.com>
yuqi1129 pushed a commit that referenced this issue May 23, 2024
@jerryshao @noidname01
[#3058] improvement(client-python): Correct type specification of cre…
5c7cf8b 
…ate_fileset function (#3535)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: #3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: noidname01 <55401762+noidname01@users.noreply.github.com>
Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@ch3yne @diqiu50
[apache#3058] fix(web): fix value displaying and enhance the styles (a…
cc683e4 
…pache#3102)

### What changes were proposed in this pull request?

Fix value displaying and enhance the styles.

### Why are the changes needed?

Fix: apache#3058

### Does this PR introduce _any_ user-facing change?

`[['id', 'b'], ['name'], ['d', 'e'], ['f'], ['g']]`

header:
<img width="129" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/5206bd0c-a3d6-487c-a623-52d91b2429cf">
column:
<img width="219" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/da060e00-a472-4df5-98f7-8b4feda51ea8">


others:

<img width="157" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/364ff92d-8472-4c5e-ace0-30e709f84c5c">

<img width="196" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/a0dc67f4-1b2f-4481-945c-b0bc773e0735">

<img width="148" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/02463cf3-8e7c-40c5-a73a-a2dbea8392ce">

<img width="182" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/e9578950-7686-4b70-9216-14b987d88181">

<img width="175" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/eb62d830-d6a5-4eea-817b-adaded5c04ae">

<img width="217" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/933a4554-3e5f-4b04-b04f-2d0e84e4a734">


### How was this patch tested?

local
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@noidname01 @diqiu50
[apache#3058] improvement(client-python): Correct type specification …
6d9b51f 
…of create_fileset function (apache#3509)

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: apache#3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#3058] fix(web): fix value displaying and enhance the styles ch3yne/gravitino
3 participants
@jerryshao @yuqi1129 @ch3yne