Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Add Pylint Rules for client-python naming rules #3205

Closed
Tracked by #3203
noidname01 opened this issue Apr 29, 2024 · 0 comments · Fixed by #3369
Closed
Tracked by #3203

[Subtask] Add Pylint Rules for client-python naming rules #3205

noidname01 opened this issue Apr 29, 2024 · 0 comments · Fixed by #3369
Assignees
@noidname01
Labels
subtask Subtasks of umbrella issue

Comments

@noidname01
Copy link
Collaborator

noidname01 commented Apr 29, 2024 •
edited
Loading

Describe the subtask

  • There are no naming and spacing in project rules, we should add them in pylint

Parent issue

#3203
@noidname01 noidname01 added the subtask Subtasks of umbrella issue label Apr 29, 2024
@noidname01 noidname01 changed the title [Subtask] Add Pylint Rules for client-python naming and spacing rules [Subtask] Add Pylint Rules for client-python naming rules Apr 30, 2024
@noidname01 noidname01 mentioned this issue Apr 30, 2024
Closed
2 tasks
@noidname01 noidname01 mentioned this issue May 13, 2024
Merged
jerryshao pushed a commit that referenced this issue May 13, 2024
@noidname01
[#3205] improvement(client-python): Apply naming convention to client…
0a3caed 
…-python (#3369)

### What changes were proposed in this pull request?

- Define naming style of each class, module, function and variable
- See `pylintrc` for detail settings

### Why are the changes needed?

Fix: #3205 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
github-actions bot pushed a commit that referenced this issue May 13, 2024
@noidname01 @web-flow
[#3205] improvement(client-python): Apply naming convention to client…
21958db 
…-python (#3369)

### What changes were proposed in this pull request?

- Define naming style of each class, module, function and variable
- See `pylintrc` for detail settings

### Why are the changes needed?

Fix: #3205 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
@jerryshao jerryshao mentioned this issue May 13, 2024
Merged
yuqi1129 pushed a commit that referenced this issue May 14, 2024
@jerryshao @noidname01
[#3205] improvement(client-python): Apply naming convention to client…
dfde153 
…-python (#3372)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

- Define naming style of each class, module, function and variable
- See `pylintrc` for detail settings

### Why are the changes needed?

Fix: #3205 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

Co-authored-by: noidname01 <55401762+noidname01@users.noreply.github.com>
Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@noidname01 @diqiu50
[apache#3205] improvement(client-python): Apply naming convention to …
8726db3 
…client-python (apache#3369)

### What changes were proposed in this pull request?

- Define naming style of each class, module, function and variable
- See `pylintrc` for detail settings

### Why are the changes needed?

Fix: apache#3205 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
coolderli pushed a commit that referenced this issue Dec 17, 2024
@noidname01
[#3205] improvement(client-python): Apply naming convention to client…
5f0ea5f 
…-python (#3369)

### What changes were proposed in this pull request?

- Define naming style of each class, module, function and variable
- See `pylintrc` for detail settings

### Why are the changes needed?

Fix: #3205

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>

(cherry picked from commit 0a3caed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noidname01 noidname01

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3205] improvement(client-python): Apply naming convention to client-python noidname01/gravitino
2 participants
@jerryshao @noidname01