Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Gravitino UI when creating a new fileset catalog it seems to be missing location property #3257

Closed
justinmclean opened this issue May 3, 2024 · 1 comment · Fixed by #3384
Closed

[Bug report] Gravitino UI when creating a new fileset catalog it seems to be missing location property #3257

justinmclean opened this issue May 3, 2024 · 1 comment · Fixed by #3384
Assignees
@LauraXia123
Labels
bug Something isn't working

Comments

@justinmclean
Copy link
Member

justinmclean commented May 3, 2024 •
edited
Loading

Version

main branch

Describe what's wrong

When creating a new fileset there are no properties. Is this expected?
image

Error message and/or stacktrace

N/A

How to reproduce

Using the 0.5 release, create a new fileset catalog in the Gravitino UI.

Additional context

No response
@justinmclean justinmclean added the bug Something isn't working label May 3, 2024
@shaofengshi
Copy link
Contributor

+1; Although the location property is optional, it is better to be there for ease of use.

@justinmclean justinmclean changed the title [Bug report] Gravitino UI when creating a new fileset catalog seem to be misisng location property [Bug report] Gravitino UI when creating a new fileset catalog it seems to be missing location property May 6, 2024
LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue May 14, 2024
@LauraXia123
[apache#3257]fix(ui): add a default optional properties for fileset c…
c3b6a1c 
…atalog
@LauraXia123 LauraXia123 self-assigned this May 14, 2024
@LauraXia123 LauraXia123 mentioned this issue May 14, 2024
Merged
github-actions bot pushed a commit that referenced this issue May 15, 2024
@LauraXia123 @web-flow
[#3257] fix(web): add a default optional properties for fileset catal…
9b7ac90 
…og (#3384)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Add a default optional properties for fileset catalog
<img width="597" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/1fe02e25-d80e-4182-bb47-6079b956fe39">
Remove fix width of version component
<img width="289" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/cbc690cd-d721-4916-9d5d-1dea077499d5">
<img width="335" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/19ab6609-32cf-44e1-9bc0-e2eb12241ab0">


### Why are the changes needed?
Although the location property is optional, it is better to be there for
ease of use
The width of version component is should be flexible

Fix: #3257

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
@jerryshao jerryshao mentioned this issue May 15, 2024
Merged
LauraXia123 added a commit that referenced this issue May 15, 2024
@jerryshao @LauraXia123
[#3257] fix(web): add a default optional properties for fileset catal…
aa9da3b 
…og (#3393)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Add a default optional properties for fileset catalog
<img width="597" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/1fe02e25-d80e-4182-bb47-6079b956fe39">
Remove fix width of version component
<img width="289" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/cbc690cd-d721-4916-9d5d-1dea077499d5">
<img width="335" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/19ab6609-32cf-44e1-9bc0-e2eb12241ab0">


### Why are the changes needed?
Although the location property is optional, it is better to be there for
ease of use
The width of version component is should be flexible

Fix: #3257

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual

Co-authored-by: Qian Xia <lauraxiaqian@gmail.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@LauraXia123 @diqiu50
[apache#3257] fix(web): add a default optional properties for fileset…
a6b88af 
… catalog (apache#3384)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Add a default optional properties for fileset catalog
<img width="597" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/1fe02e25-d80e-4182-bb47-6079b956fe39">
Remove fix width of version component
<img width="289" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/cbc690cd-d721-4916-9d5d-1dea077499d5">
<img width="335" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/19ab6609-32cf-44e1-9bc0-e2eb12241ab0">


### Why are the changes needed?
Although the location property is optional, it is better to be there for
ease of use
The width of version component is should be flexible

Fix: apache#3257

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3257] fix(web): add a default optional properties for fileset catalog LauraXia123/gravitino
4 participants
@justinmclean @jerryshao @shaofengshi @LauraXia123