Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] Refactoring SupportsCatalogs.listCatalogs() method in client side #3702

Closed
shaofengshi opened this issue May 31, 2024 · 0 comments · Fixed by #3741
Closed

[Subtask] Refactoring SupportsCatalogs.listCatalogs() method in client side #3702

shaofengshi opened this issue May 31, 2024 · 0 comments · Fixed by #3741
Assignees
Labels
0.6.0 Release v0.6.0 subtask Subtasks of umbrella issue

Comments

@shaofengshi
Copy link
Contributor

Describe the subtask

Currently, the SupportsCatalogs.listCatalogs() method returns an array of NameIdentifier to represents the catalogs. Actually a String[] will be more clear and easier to use.

Parent issue

#3626

@shaofengshi shaofengshi added the subtask Subtasks of umbrella issue label May 31, 2024
@shaofengshi shaofengshi self-assigned this May 31, 2024
shaofengshi added a commit to shaofengshi/gravitino that referenced this issue Jun 4, 2024
jerryshao pushed a commit that referenced this issue Jun 5, 2024
…hod to return String[] (#3741)

### What changes were proposed in this pull request?

Currently, the SupportsCatalogs.listCatalogs() method returns an array
of NameIdentifier to represents the catalogs. Actually a String[] will
be more clear and easier to use.

### Why are the changes needed?

To make the API more clear to use.

Fix: #3702

### Does this PR introduce _any_ user-facing change?

Almost not; Just return type changed, will be more simple.

### How was this patch tested?

Yes, many test cases cover this API.
@jerryshao jerryshao added the 0.6.0 Release v0.6.0 label Jun 5, 2024
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
…() method to return String[] (apache#3741)

### What changes were proposed in this pull request?

Currently, the SupportsCatalogs.listCatalogs() method returns an array
of NameIdentifier to represents the catalogs. Actually a String[] will
be more clear and easier to use.

### Why are the changes needed?

To make the API more clear to use.

Fix: apache#3702

### Does this PR introduce _any_ user-facing change?

Almost not; Just return type changed, will be more simple.

### How was this patch tested?

Yes, many test cases cover this API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6.0 Release v0.6.0 subtask Subtasks of umbrella issue
Projects
None yet
2 participants