Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Update Python client to align with the Java client API #3732

Closed
shaofengshi opened this issue Jun 3, 2024 · 3 comments · Fixed by #4025 or #4046
Closed

[Subtask] Update Python client to align with the Java client API #3732

shaofengshi opened this issue Jun 3, 2024 · 3 comments · Fixed by #4025 or #4046
Assignees
@LanceHsun
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue

Comments

@shaofengshi
Copy link
Contributor

Describe the subtask

After the refactoring work in Java client is done (#3626), the Python client should also get updated to align with the Java API.

Parent issue

#3626
@shaofengshi shaofengshi added good first issue Good for newcomers subtask Subtasks of umbrella issue labels Jun 3, 2024
This was referenced Jun 3, 2024
Closed
Merged
@shaofengshi
Copy link
Contributor Author

shaofengshi commented Jun 6, 2024 •
edited by LanceHsun
Loading

@LanceHsun Lance, would you like to take this?

@LanceHsun LanceHsun self-assigned this Jun 7, 2024
@LanceHsun
Copy link
Contributor

@LanceHsun Lance, would you like to take this?

Hi Shaofeng, yes, I have already assigned it to me. Thank you!

@shaofengshi shaofengshi mentioned this issue Jul 2, 2024
Merged
@xunliu xunliu closed this as completed in 1134386 Jul 3, 2024
@shaofengshi
Copy link
Contributor Author

Reopen this as there are other on-going tasks being made by Lance and Tim.

@shaofengshi shaofengshi reopened this Jul 3, 2024
@noidname01 noidname01 mentioned this issue Jul 3, 2024
Merged
shaofengshi pushed a commit that referenced this issue Jul 3, 2024
@noidname01
[#3732] refactor(client-python): Update Python client to align with t…
554ce49 
…he Java client API (#4046)

### What changes were proposed in this pull request?

After the refactoring work in Java client is done
(#3626), the Python client
should also get updated to align with the Java API.

* Update all the catalog, schema and their implementation to align with
`client-java`
* Remove redundant methods in `Namespace` and `NameIdentifier`
* Add some missing tests and modify existing tests to conform with new
API

### Why are the changes needed?

Fix: #3732 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

UT added and test with `./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LanceHsun LanceHsun

Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
2 participants
@shaofengshi @LanceHsun