[Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload

[liuchunhao]

Version

main branch

Describe what's wrong

The property key warehouse was removed with rest assigned as a catalog-backend on Web UI, but REST API call for creating a catalog still requires warehouse in the request body and missing warehouse in the HTTP request body will cause the exception below.

No option warehouse provided with restcatalog-backend on Web UI

POST http://localhost:8090/api/metalakes/test/catalogs

{
  "name": "1",       
  "type": "relational", 
  "provider": "lakehouse-iceberg",
  "comment": "",      
  "properties": {
    "uri": "1",
    // "warehouse": "",   // Why is this a required property ?
    "catalog-backend": "rest",
    "authType": "simple"
  }
}

API call without “warehouse” causes the exception below:

{
    "code": 1001,
    "type": "IllegalArgumentException",
    "message": "Failed to operate catalog(s) [100] operation [CREATE] under metalake [test], reason [Properties are required and must be set: [warehouse]]",
    "stack": [
        ...
     ]
}

Error message and/or stacktrace

{
    "code": 1001,
    "type": "IllegalArgumentException",
    "message": "Failed to operate catalog(s) [100] operation [CREATE] under metalake [test], reason [Properties are required and must be set: [warehouse]]",
    "stack": [
        ...
     ]
}

How to reproduce

Create a test metalake and then create a catalog by sending the request without warehouse to the REST API as follows :

POST http://localhost:8090/api/metalakes/test/catalogs

{
  "name": "1",       
  "type": "relational", 
  "provider": "lakehouse-iceberg",
  "comment": "",      
  "properties": {
    "uri": "1",
    "catalog-backend": "rest",
    "authType": "simple"
  }
}

Additional context

No response

[FANNG1]

warehouse is not required for Iceberg REST catalog backend. we should not check the exists of warehouse for REST catalog backend in https://github.com/apache/gravitino/blob/main/iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java#L89 , @liuchunhao would you like to fix it?

[liuchunhao]

Sure, I'd be happy to handle it.

[jerryshao]

@fsalhi2 would you please leave an comment here, so I can assign the issue to you, thanks.

[fsalhi2]

Hi @jerryshao , here am i :)