New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Delete a table with a missing table name causes an obscure error in the Gravitino CLI #5827

Closed

justinmclean opened this issue Dec 11, 2024 · 1 comment · Fixed by #5906

Assignees

Labels

good first issue improvement

Member

justinmclean commented Dec 11, 2024

What would you like to be improved?

When running the command gcli table delete --metalake metalake_demo --name catalog_postgres.hr you get the error Cannot create a NameIdentifier with null or empty name.

How should we improve?

Make the error more user friendly.

The text was updated successfully, but these errors were encountered:

justinmclean added good first issue improvement labels

Contributor

Abyss-lord commented Dec 16, 2024

I would like to work on it.

justinmclean assigned Abyss-lord

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

874096c

Fix cli throws an obscure error when Delete a table with a missing table name.it should give clearer hints.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

fdc2b8c

add some test case to test whether the command fuse is executed correctly

Abyss-lord mentioned this issue

[#5827] improvement(CLI): Fix CLI throws an obscure error when Delete a table with a missing table name #5906

Merged

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

Fix cli throws an obscure error when Delete a table with a missing table name.it should give clearer hints.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

e2e6da1

add some test case to test whether the command fuse is executed correctly

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

0e7b877

Fix cli throws an obscure error when Delete a table with a missing table name.it should give clearer hints.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

a66d932

add some test case to test whether the command fuse is executed correctly

Abyss-lord mentioned this issue

[#5826] fix(CLI): Fix Dropping a metalake via the Gravitino CLI gives an "in use" exception #5907

Merged

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          Revert "[apache#5827] improvement(CLI): fix cli throws an obscure error"

20ce488

This reverts commit fdc2b8c.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

20b5058

fix test case

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

7c8d19e

Fix cli throws an obscure error when Delete a table with a missing table name.it should give clearer hints.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

f5c8462

add some test case to test whether the command fuse is executed correctly

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          Revert "[apache#5827] improvement(CLI): fix cli throws an obscure error"

c8955b5

This reverts commit fdc2b8c.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

f06af4f

fix test case

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

31e1750

add some test case to test whether the command fuse is executed correctly

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

3148fe8

fix error message and test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

7b6de14

fix  test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

bc0bf34

fix test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

34e7bdf

fix test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

d3a7375

fix test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

0a04739

fix test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

bed6232

fix check null expression.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

ac943f3

fix ci fail

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

fix ci fail and change the error message.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): Add test case

ee978b8

add enable/disable metalake and catalog test case

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): Add test case

e5e7ed3

add enable/disable metalake and catalog test case

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

509e411

move handling of LIST command "back" to the switch case and fix the test case.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          Revert "[apache#5827] improvement(CLI): fix cli throws an obscure error"

c63419c

This reverts commit 509e411.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): fix cli throws an obscure error

89d9b27

fix test case and list logic

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): Add test case

5dfe6ce

add enable/disable metalake and catalog test case

justinmclean closed this as completed in #5906

justinmclean closed this as completed in

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): Fix CLI throws an obscure error when …

d2d9f8d

…Delete a table with a missing table name (apache#5906)

### What changes were proposed in this pull request?

Fix CLI throws an obscure error when Delete a table with a missing table
name.it should give clearer hints.

### Why are the changes needed?

Fix: apache#5827 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

#### local bash test

```bash
bin/gcli.sh table delete --metalake demo_metalake
Missing required argument(s): catalog, schema, table

bin/gcli.sh table delete --metalake demo_metalake --name Hive_catalog
# output: Missing required argument(s): schema, table

bin/gcli.sh table delete --metalake demo_metalake --name Hive_catalog.default
# output: Missing required argument(s): table

bin/gcli.sh table details --metalake demo_metalake --name Hive_catalog.default
# output
# Malformed entity name.
# Missing required argument(s): table
```

#### Unit test

add some test case to test whether the command fuse is executed
correctly.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue


          [apache#5827] improvement(CLI): Fix CLI throws an obscure error when …

663f25e

…Delete a table with a missing table name (apache#5906)

### What changes were proposed in this pull request?

Fix CLI throws an obscure error when Delete a table with a missing table
name.it should give clearer hints.

### Why are the changes needed?

Fix: apache#5827 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

#### local bash test

```bash
bin/gcli.sh table delete --metalake demo_metalake
Missing required argument(s): catalog, schema, table

bin/gcli.sh table delete --metalake demo_metalake --name Hive_catalog
# output: Missing required argument(s): schema, table

bin/gcli.sh table delete --metalake demo_metalake --name Hive_catalog.default
# output: Missing required argument(s): table

bin/gcli.sh table details --metalake demo_metalake --name Hive_catalog.default
# output
# Malformed entity name.
# Missing required argument(s): table
```

#### Unit test

add some test case to test whether the command fuse is executed
correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment