Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Gravitino CLI should exit with -1 if an error is encounted #5896

Closed
justinmclean opened this issue Dec 17, 2024 · 0 comments · Fixed by #5903
Closed

[Improvement] Gravitino CLI should exit with -1 if an error is encounted #5896

justinmclean opened this issue Dec 17, 2024 · 0 comments · Fixed by #5903
Assignees
@justinmclean
Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

A good practice is to exit with -1 when an error occurs.

How should we improve?

See above.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 17, 2024
@justinmclean justinmclean self-assigned this Dec 18, 2024
@justinmclean justinmclean changed the title [Improvement] Gavititine CLI should exit with -1 if an error is encounted [Improvement] Gravitino CLI should exit with -1 if an error is encounted Dec 18, 2024
@justinmclean justinmclean mentioned this issue Dec 18, 2024
Merged
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Dec 20, 2024
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
@justinmclean @shaofengshi @Abyss-lord
[apache#5896] Exit with -1 when an error occurs in the Gravitino CLI (a…
d5d5a9d 
…pache#5903)

### What changes were proposed in this pull request?

Changed to exit with -1 if an error occurs. Not that testing code that
calls System.exit can be difficult, so during testing it thows an
exception and doesn't exit the VM.

Testing also uncovered one bug in updating column default values and
this was fixed.

### Why are the changes needed?

So scripts can test if the gcli command works.

Fix: apache#5896

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested locally.

---------

Co-authored-by: Shaofeng Shi <shaofengshi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5896] Exit with -1 when an error occurs in the Gravitino CLI justinmclean/gravitino
2 participants
@justinmclean @jerryshao