Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In the Gravitino CLI a user details command can produce no output #5929

Closed
justinmclean opened this issue Dec 20, 2024 · 2 comments · Fixed by #5941
Closed

[Improvement] In the Gravitino CLI a user details command can produce no output #5929

justinmclean opened this issue Dec 20, 2024 · 2 comments · Fixed by #5941
Assignees
@Abyss-lord
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

If a user has no roles then no output is produced from this command gcli user details --metalake metalake_demo --user new_user -i

How should we improve?

Output "User has no roles." or similar.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Dec 20, 2024
@justinmclean
Copy link
Member Author

Same issue exists with gcli group details --metalake metalake_demo --group new_group -i, so it would be best if this is fixed at the same time.

@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 22, 2024
@Abyss-lord
[apache#5929] improvement(CLI): fix cli details command produce no ou…
e6f3a39 
…tput

If a user has no roles then no output is produced from user\group details command, it should give some help information.
@Abyss-lord Abyss-lord mentioned this issue Dec 22, 2024
Merged
xunliu pushed a commit that referenced this issue Dec 23, 2024
@Abyss-lord @tengqm
[#5929] improvement(CLI): fix cli details command produce no output (#…
66eb83b 
…5941)

### What changes were proposed in this pull request?

If a user has no roles then no output is produced from `user\group
details` command, it should give some help information.

### Why are the changes needed?

Fix: #5929 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

```bash
bin/gcli.sh user details -m demo_metalake --user test_user
# output: User has no roles.

bin/gcli.sh group details -m demo_metalake --group group_no_role
# output: Groups has no roles.
```

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 23, 2024
@Abyss-lord @tengqm
[apache#5929] improvement(CLI): fix cli details command produce no ou…
9731aa4 
…tput (apache#5941)

### What changes were proposed in this pull request?

If a user has no roles then no output is produced from `user\group
details` command, it should give some help information.

### Why are the changes needed?

Fix: apache#5929 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

```bash
bin/gcli.sh user details -m demo_metalake --user test_user
# output: User has no roles.

bin/gcli.sh group details -m demo_metalake --group group_no_role
# output: Groups has no roles.
```

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Dec 29, 2024
@Abyss-lord @tengqm
[apache#5929] improvement(CLI): fix cli details command produce no ou…
77bd191 
…tput (apache#5941)

### What changes were proposed in this pull request?

If a user has no roles then no output is produced from `user\group
details` command, it should give some help information.

### Why are the changes needed?

Fix: apache#5929 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

```bash
bin/gcli.sh user details -m demo_metalake --user test_user
# output: User has no roles.

bin/gcli.sh group details -m demo_metalake --group group_no_role
# output: Groups has no roles.
```

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5929] improvement(CLI): fix cli details command produce no output Abyss-lord/gravitino
2 participants
@justinmclean @Abyss-lord