Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Dependencies follow the alphabet order #738

Closed
qqqttt123 opened this issue Nov 14, 2023 · 6 comments · Fixed by #1703
Closed

[Improvement] Dependencies follow the alphabet order #738

qqqttt123 opened this issue Nov 14, 2023 · 6 comments · Fixed by #1703
Assignees
@hiirrxnn
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@qqqttt123
Copy link
Contributor

What would you like to be improved?

Dependencies follow the alphabet order

How should we improve?

No response
@qqqttt123 qqqttt123 added the improvement Improvements on everything label Nov 14, 2023
@qqqttt123 qqqttt123 mentioned this issue Nov 14, 2023
Merged
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 14, 2023
@jerryshao jerryshao added the good first issue Good for newcomers label Dec 25, 2023
@jerryshao jerryshao removed this from the Gravitino 0.4.0 milestone Dec 25, 2023
@hiirrxnn
Copy link
Contributor

Can i take up this issue ?

@hiirrxnn
Copy link
Contributor

In which file/files should I sort the dependencies?

@yuqi1129
Copy link
Contributor

@qqqttt123
Could you help to clarify it?

@hiirrxnn
Copy link
Contributor

Is it a specific build.gradle.kts file or all ? Also , just the "implementation(xx)" ones or the "exclude(xx)" ones too ?

@qqqttt123
Copy link
Contributor Author

qqqttt123 commented Jan 23, 2024 •
edited
Loading

Is it a specific build.gradle.kts file or all ? Also , just the "implementation(xx)" ones or the "exclude(xx)" ones too ?

All build.gradle.kts files.

@hiirrxnn hiirrxnn mentioned this issue Jan 25, 2024
Merged
@justinmclean
Copy link
Member

@hiirrxnn how are you going with this? Do you need any help?

yuqi1129 added a commit that referenced this issue Feb 11, 2024
@hiirrxnn @yuqi1129
[#738]:Dependencies follow alphabetical order (#1703)
fbcd416 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Dependencies follow alphabetical order

### Why are the changes needed?
For better readability
Fix: #738 
### Does this PR introduce _any_ user-facing change?
N/A
### How was this patch tested?

N/A

---------

Co-authored-by: Qi Yu <yuqi@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiirrxnn hiirrxnn

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#738]:Dependencies follow alphabetical order hiirrxnn/gravitino
5 participants
@justinmclean @jerryshao @yuqi1129 @hiirrxnn @qqqttt123