Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] AddColumn supports adding default values #839

Closed
Clearvive opened this issue Nov 27, 2023 · 0 comments · Fixed by #2558
Closed

[FEATURE] AddColumn supports adding default values #839

Clearvive opened this issue Nov 27, 2023 · 0 comments · Fixed by #2558
Assignees
@mchades
Milestone
Gravitino 0.5.0

Comments

@Clearvive
Copy link
Contributor

Describe the feature

In the implementation of underlying storage systems, columns often have default values and properties, as well as whether they are null. It is hoped that the AddColumn can be specified

Motivation

No response

Describe the solution

No response

Additional context

No response
@Clearvive Clearvive self-assigned this Nov 27, 2023
@Clearvive Clearvive mentioned this issue Nov 27, 2023
Merged
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 4, 2023
@Clearvive Clearvive removed their assignment Jan 29, 2024
@mchades mchades changed the title [FEATURE] AddColumn supports adding default values and properties [FEATURE] AddColumn supports adding default values Mar 5, 2024
@zivali zivali mentioned this issue Mar 16, 2024
Merged
jerryshao pushed a commit that referenced this issue Apr 3, 2024
@zivali
[#839] feat: AddColumn supports adding default values (#2558)
e7d5d23 
### What changes were proposed in this pull request?
Supports setting default value when adding column.
- MySQL & PostgreSQL are supported
- Hive & Iceberg are not supported -> throws exception

### Why are the changes needed?
Fix: #839

### Does this PR introduce _any_ user-facing change?
Users are able to set default value for column when adding column with
`com.datastrato.gravitino.rel.TableCatalog#alterTable`

### How was this patch tested?
Add tests of adding columns with default value in existing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
None yet
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#839] feat: AddColumn supports adding default values zivali/gravitino
3 participants
@jerryshao @mchades @Clearvive