[#1154] fix(trino-connector): Fix the issue with joins causing errors in PostgreSQL. #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Dec 18, 2023
| return internalSplitManager.getSplits( | ||
| gravitinoTransactionHandle.getInternalTransactionHandle(), | ||
| session, | ||
| gravitinoTableHandle.getInternalTableHandle(), | ||
| dynamicFilter, | ||
| DynamicFilter.EMPTY, |
There was a problem hiding this comment.
When will we use a non-null dynamicFilter?
Can you explain the real cause of the problem more clearly?
There was a problem hiding this comment.
In the current implementation of dynamicFilter, it includes ColumnHandle, and this columnhandle is currently GravitinoColumnHandle. When it's passed to the following internal connector, such as PG, it will throw an error. The PG connector only accepts JDBCColumnHandle. Here, we pass DynamicFilter.EMPTY, which can temporarily solve this problem.
qqqttt123
added
branch-0.3
need backport
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
… in PostgreSQL. (#1177) ### What changes were proposed in this pull request? Fix the issue with joins causing errors in PostgreSQL. Error message is "Cannot cast com.datastrato.gravitino.trino.connector.GravitinoColumnHandle to io.trino.plugin.jdbc.JdbcColumnHandle" ### Why are the changes needed? Fix: #1154 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the issue with joins causing errors in PostgreSQL.
Error message is "Cannot cast com.datastrato.gravitino.trino.connector.GravitinoColumnHandle to io.trino.plugin.jdbc.JdbcColumnHandle"
Why are the changes needed?
Fix: #1154
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT