[#1113][#1224] improvement(UI): TS support and improve global request handing #1308
Conversation
|
There is no need to add web/licenses/typescript.txt as we already have the ALv2 text in full. |
|
You also need to add the product that is "MIT License Copyright (c) 2020-present, Vben" to LICENSE. |
web/LICENSE.bin
Outdated
|
|
||
| This product bundles various third-party components also under the | ||
| MIT license. | ||
|
|
||
| MIT License Copyright (c) 2020-present, Vben |
There was a problem hiding this comment.
@justinmclean Is this the correct format for adding it?
There was a problem hiding this comment.
you need to list the product name not the license and copyright
Removed. |
ch3yne
changed the title
|
Does this pull request need to back port branch 0.3? |
ch3yne
changed the title
I think it's needed. |
jerryshao
added
branch-0.3
need backport
| errMessage = 'The http version does not support the request!' | ||
| break | ||
|
|
||
| default: |
There was a problem hiding this comment.
Are these error messages all defined messages? I think we (Gravitino) have our error message, should we use the Gravitino's returned error message?
|
Seems there're some building issues we need to fix. @ch3yne |
|
@justinmclean can you please help to check Iicense related things, thanks! |
… handing (#1308) ### What changes were proposed in this pull request? 1. Support TypeScript 2. Improve global reauest handing and add error messages ### Why are the changes needed? Fix: #1113 Fix: #1224 Fix: #1225 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #1113
Fix: #1224
Fix: #1225
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A