[#1632] fix(jdbc-mysql): Supporting create not null column for MySQL table. #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
requested review from
diqiu50 and
Clearvive
and removed request for
diqiu50
diqiu50
reviewed
Jan 22, 2024
...ion-test/src/test/java/com/datastrato/gravitino/integration/test/trino/TrinoConnectorIT.java
Show resolved
Hide resolved
|
PG has no such problem. |
|
@diqiu50 |
diqiu50
reviewed
Jan 23, 2024
integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00002_alter_table.sql
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 23, 2024
| @@ -435,8 +434,7 @@ private String updateColumnCommentFieldDefinition( | |||
| return "MODIFY COLUMN " + col + appendColumnDefinition(updateColumn, new StringBuilder()); | |||
| } | |||
|
|
|||
| private String addColumnFieldDefinition( | |||
| TableChange.AddColumn addColumn, CreateTable createTable) { | |||
| private String addColumnFieldDefinition(TableChange.AddColumn addColumn) { | |||
There was a problem hiding this comment.
besides trino test, could you add a mysql test?
|
Do we also need to support this for PG? |
No, I have checked PG has no such issue. 
|
mchades
pushed a commit
to mchades/gravitino
that referenced
this pull request
Jan 24, 2024
…MySQL table. (apache#1637) ### What changes were proposed in this pull request? Add `NOT NULL` key word in create table sentence if column type is NOT NULL. ### Why are the changes needed? We should support creating a table with not null columns. Fix: apache#1632 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? Add some ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
NOT NULLkey word in create table sentence if column type is NOT NULL.Why are the changes needed?
We should support creating a table with not null columns.
Fix: #1632
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Add some ITs.