Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2154] improvement: enable EqualsGetClass error-prone check #2333

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

coolderli
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

  • no

How was this patch tested?

./gradlew build and UTs

@coolderli coolderli closed this Feb 24, 2024
@coolderli coolderli reopened this Feb 24, 2024
@coolderli
Copy link
Contributor Author

@justinmclean Please help me review this when you have time. Thanks.

Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - thanks for your contribution.

Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @coolderli for your work.

@jerryshao jerryshao merged commit c4325f4 into apache:main Feb 26, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Column.java Prefer instanceof to getClass
3 participants