[#2566] Improvement(spark-connector): Refactoring integration tests for spark-connector #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caican00
changed the title
FANNG1
reviewed
Mar 19, 2024
...ration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
caican00
changed the title
…r spark-connector
…o seperate-spark-it
…r spark-connector
FANNG1
reviewed
Mar 19, 2024
...ration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 19, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkEnvIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 19, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkEnvIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 19, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkEnvIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Mar 19, 2024
...ration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Mar 19, 2024
...ration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkCommonIT.java
Show resolved
Hide resolved
|
all comments have been addressed. cc @FANNG1 |
FANNG1
reviewed
Mar 19, 2024
integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkEnvIT.java
Outdated
Show resolved
Hide resolved
|
LGTM, except one minor comment |
comment has been addressed. |
|
let's wait for the CI to finish |
FANNG1
approved these changes
Mar 19, 2024
|
@caican00 merged to main, thanks for your work! |
Thanks for review and merge. |
coolderli
pushed a commit
to coolderli/gravitino
that referenced
this pull request
Apr 2, 2024
…ests for spark-connector (apache#2578) ### What changes were proposed in this pull request? 1. Make SparkIT to SparkCommonIT which contains the common tests shared by all catalogs. 2. Add new SparkHiveCatalogIT to test Hive specific tests, and both SparkXXCatalogIT extends SparkCommonIT. ### Why are the changes needed? Separate integration testing for different data sources. Fix: apache#2566 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Integration tests after separation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make SparkIT to SparkCommonIT which contains the common tests shared by all catalogs.
Add new SparkHiveCatalogIT to test Hive specific tests, and both SparkXXCatalogIT extends SparkCommonIT.
Why are the changes needed?
Separate integration testing for different data sources.
Fix: #2566
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration tests after separation.