Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2625] fix: cannot compile under docker bash #2626

Closed
wants to merge 2 commits into from
Closed

[#2625] fix: cannot compile under docker bash #2626

wants to merge 2 commits into from

Conversation

liujinhui1994
Copy link
Contributor

@liujinhui1994 liujinhui1994 commented Mar 21, 2024

What changes were proposed in this pull request?

Modified the script to get the version number in grade

Why are the changes needed?

Compiling under docker bash, the version number cannot be correctly parsed from the gradle file, causing the compilation to fail.

Fix: #2625

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Recompile successfully under docker bash

@xunliu
Copy link
Member

xunliu commented Mar 21, 2024

hi @liujinhui1994 Thank you for your contribution.
Please follow community PR norm, https://github.com/datastrato/gravitino/blob/main/.github/PULL_REQUEST_TEMPLATE
I think you should create an issue

@liujinhui1994 liujinhui1994 changed the title [#2625]Cannot compile under docker bash [#2625] Fix: cannot compile under docker bash Mar 21, 2024
@liujinhui1994 liujinhui1994 changed the title [#2625] Fix: cannot compile under docker bash [#2625] fix: cannot compile under docker bash Mar 21, 2024
@liujinhui1994
Copy link
Contributor Author

liujinhui1994 commented Mar 21, 2024

hi @liujinhui1994 Thank you for your contribution. Please follow community PR norm, https://github.com/datastrato/gravitino/blob/main/.github/PULL_REQUEST_TEMPLATE I think you should create an issue

Thanks for the tip,done

@jerryshao
Copy link
Contributor

What is the root cause here, why does this change work, and why it could not be worked previously?

@liujinhui1994
Copy link
Contributor Author

What is the root cause here, why does this change work, and why it could not be worked previously?

This modification is to obtain the tag number.
It is a string interception operation. The previous code cannot take effect under docker bash, resulting in the failure to obtain the correct version number and compilation failure.

@jerryshao
Copy link
Contributor

I think you still don't tell why it cannot be worked in the docker environment, right?

@liujinhui1994 liujinhui1994 closed this by deleting the head repository Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Cannot compile under docker bash
3 participants