Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2238] feat(server): Add the operations for the user #2733

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

qqqttt123
Copy link
Contributor

What changes were proposed in this pull request?

Add the operations for the user.

Why are the changes needed?

Fix: #2238

Does this PR introduce any user-facing change?

Yes, I will add the open api and the document in the later pr.

How was this patch tested?

Add a new UT.

@qqqttt123 qqqttt123 marked this pull request as draft March 29, 2024 07:01
() -> {
NameIdentifier ident = ofUser(metalake, user);
boolean removed =
TreeLockUtils.doWithTreeLock(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqi1129 Could you help me review the use of lock?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part maybe changed after #2732 , let's wait for a while.

@qqqttt123 qqqttt123 self-assigned this Mar 29, 2024
@qqqttt123 qqqttt123 marked this pull request as ready for review March 29, 2024 08:04
@qqqttt123 qqqttt123 requested a review from jerryshao March 29, 2024 08:04
@jerryshao
Copy link
Contributor

LGTM, @yuqi1129 would you please double the usage of tree lock here?

@yuqi1129
Copy link
Contributor

yuqi1129 commented Apr 1, 2024

LGTM, @yuqi1129 would you please double the usage of tree lock here?

No problem was found here, so it's okay for me with the changes.

@jerryshao
Copy link
Contributor

OK, I think we can change the whole lock mechanism in #2732 if necessary, we don't have to block this PR.

@jerryshao jerryshao merged commit 0dcd308 into apache:main Apr 1, 2024
19 checks passed
@qqqttt123 qqqttt123 deleted the ISSUE-2238 branch April 2, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Add an operation class for user
3 participants