[#2236] feat(core): Add the support of Group entity #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 17:49
jerryshao
reviewed
Mar 29, 2024
|
|
||
| /** The interface of a Group. The Group is the entity which contains users. */ | ||
| @Evolving | ||
| public interface Group extends Auditable { |
There was a problem hiding this comment.
How does Gravitino know which user belongs to which group?
There was a problem hiding this comment.
We can get the groups by using user name in the AuthorizationFilter. We can use user name to retrieve the groups from the external user system like LDAP, RANGER, IAM.
I will add GroupMappingServiceProvider for accomplish this feature.
interface GroupMappingServiceProvider {
List<String> getGroups(String user);
}
jerryshao
reviewed
Mar 29, 2024
| * manage group, just sets up the relationship between the metalake and the group. Metalake is like | ||
| * a concept of the organization. `AddGroup` means that a group enter an organization. | ||
| */ | ||
| public class GroupManager { |
There was a problem hiding this comment.
I think we can merge the User and GroupManager together as "UserGroupManager", WDYT?
added 3 commits
March 29, 2024 20:01
jerryshao
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the support of Group entity
Why are the changes needed?
Fix: #2236
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a new UT.