[#2886] improvement(ci): optimize Docker container to suite CI framework #2887
Conversation
dev/docker/doris/start.sh
Outdated
| @@ -37,6 +36,7 @@ PRIORITY_NETWORKS=$(echo "${CONTAINER_IP}" | awk -F '.' '{print$1"."$2"."$3".0/2 | |||
| echo "add priority_networks = ${PRIORITY_NETWORKS} to fe.conf & be.conf" | |||
| echo "priority_networks = ${PRIORITY_NETWORKS}" >> ${DORIS_FE_HOME}/conf/fe.conf | |||
| echo "priority_networks = ${PRIORITY_NETWORKS}" >> ${DORIS_BE_HOME}/conf/be.conf | |||
| echo "disable_storage_medium_check = true" >> ${DORIS_FE_HOME}/conf/fe.conf | |||
There was a problem hiding this comment.
Will this configuration prevent the check for left storage when starting?
There was a problem hiding this comment.
This config is not to check storage space. This config si check storage medium to store cold data.
If disable_storage_medium_check is true, ReportHandler would not check tablet's storage medium and disable storage cool down function, the default value is false. You can set the value true when you don't care what the storage medium of the tablet is.
When we have SSD and HDD on same machine, this check is helpful.
When we use in CI, this config may cause BE refuse request, and finally make create table failed probabilistic (when the container has just been started)
I am still checking it in CI
There was a problem hiding this comment.
After test, I think we don't need to change config disable_storage_medium_check.
BUT we need to set report_disk_state_interval_seconds to 10 seconds, this config allows the BE to report storage information faster after startup. This can prevent DorisTableIT from failing.
zhoukangcn
changed the title
zhoukangcn
changed the title
zhoukangcn
force-pushed
the
doris_docker_minor
branch
from
9ed2d83 to
3cd9898
Compare
zhoukangcn
changed the title
|
@zhoukangcn |
OK，I can do it later |
zhoukangcn
force-pushed
the
doris_docker_minor
branch
from
3cd9898 to
9d798fb
Compare
zhoukangcn
force-pushed
the
doris_docker_minor
branch
from
9d798fb to
d729a3e
Compare
|
@yuqi1129 done. Please take a look when you have time. |
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #2886
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI