[#2237] feat(core): Add the support of PermissionManager #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2024 23:35
qqqttt123
changed the title
qqqttt123
changed the title
added 3 commits
April 16, 2024 00:40
qqqttt123
changed the title
jerryshao
reviewed
Apr 16, 2024
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Apr 16, 2024
| // ignore this entity | ||
| } | ||
| } | ||
| return roleEntities.stream().map(RoleEntity::name).collect(Collectors.toList()); | ||
| } | ||
| } |
There was a problem hiding this comment.
getValidXXX and removeInvalidXXX, it's the same thing, why do you implement twice?
There was a problem hiding this comment.
I will extract a common method for them.
jerryshao
reviewed
Apr 16, 2024
| List<RoleEntity> roleEntities = removeInvalidRoles(metalake, roleNames); | ||
| roleNames = Lists.newArrayList(toRoleNames(roleEntities)); | ||
| roleIds = Lists.newArrayList(toRoleIds(roleEntities)); | ||
| } |
There was a problem hiding this comment.
Does it really solve the problem? It's unrelated to GC, why do you call it GcXXX?
There was a problem hiding this comment.
I think it's a kind of GC that we remove invalid roles. If it will make people confusing, I will rename it.
jerryshao
reviewed
Apr 16, 2024
core/src/main/java/com/datastrato/gravitino/meta/GroupEntity.java
Outdated
Show resolved
Hide resolved
|
Continue to polish your code when you feel ready. I think it is not ready for review. |
|
@jerryshao I have added cache for the role. Could you review this pull request again? |
jerryshao
reviewed
Apr 17, 2024
core/src/main/java/com/datastrato/gravitino/authorization/AccessControlManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/AuthorizationUtils.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/AuthorizationUtils.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/NameIdentifierUtils.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Show resolved
Hide resolved
jerryshao
reviewed
Apr 17, 2024
core/src/main/java/com/datastrato/gravitino/authorization/PermissionManager.java
Show resolved
Hide resolved
jerryshao
reviewed
Apr 17, 2024
core/src/main/java/com/datastrato/gravitino/authorization/RoleManager.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Apr 17, 2024
core/src/main/java/com/datastrato/gravitino/authorization/UserGroupManager.java
Show resolved
Hide resolved
jerryshao
reviewed
Apr 17, 2024
core/src/main/java/com/datastrato/gravitino/authorization/UserGroupManager.java
Show resolved
Hide resolved
jerryshao
reviewed
Apr 17, 2024
added 2 commits
April 17, 2024 21:07
This reverts commit 81a4168.
|
@jerryshao All comments are addressed. |
|
CI passed. I will merge this pull request to the main branch. |
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…e#2958) ### What changes were proposed in this pull request? Add the support for permission manager. ### Why are the changes needed? Fix: apache#2237 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add a new UT. --------- Co-authored-by: Heng Qin <qqtt@123.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the support for permission manager.
Why are the changes needed?
Fix: #2237
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add a new UT.