[#3251] Improvement: fix assertion #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
justinmclean
reviewed
May 4, 2024
...connector/src/test/java/com/datastrato/gravitino/trino/connector/TestGravitinoConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
|
Can you please update the PR's description so it doesn't include the boilerplate text. |
Done @justinmclean |
justinmclean
approved these changes
May 5, 2024
jerryshao
changed the title
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[apache#123] feat(operator): support xxx"
- "[apache#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[apache#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Fixed assertion
Fix: apache#3251
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Ran test locally multiple times
---------
Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed assertion
Fix: #3251
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran test locally multiple times