Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3203] improvement(PyClient): Add pylint Rules for Python client #3279

Merged
merged 1 commit into from
May 6, 2024

Conversation

noidname01
Copy link
Collaborator

What changes were proposed in this pull request?

  • Add pylint rule for logging, logging should use old format (%), not fstring
  • Unify all the logging format
  • Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR)

Why are the changes needed?

Fix: #3203

Does this PR introduce any user-facing change?

No

How was this patch tested?

./gradlew :clients:client-python:test

…nt (apache#3204)

### What changes were proposed in this pull request?

* Add pylint rule for logging, logging should use old format (%), not
fstring
* Unify all the logging format
* Set many disable rules for future modification (I add TODO tags after
them, will work on them after this PR)

### Why are the changes needed?

Fix: apache#3203 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?
```bash
./gradlew :clients:client-python:test
```

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
@jerryshao jerryshao merged commit 7a120ab into apache:branch-0.5 May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants