[#3432] improvement(test): Add kerberos authentication IT for HDFS cluster #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #3431 |
yuqi1129
changed the title
yuqi1129
changed the title
|
@jerryshao @qqqttt123 |
|
@yuqi1129 is this PR required, do you need to update this PR? |
I think so, this PR is just to test whether we can access a kerberized HDFS cluster successfully locally to verify the docker image, a complete e2e test is ongoing. |
jerryshao
reviewed
May 22, 2024
...p/src/test/java/com/datastrato/gravitino/catalog/hadoop/integration/test/HDFSKerberosIT.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
May 22, 2024
...p/src/test/java/com/datastrato/gravitino/catalog/hadoop/integration/test/HDFSKerberosIT.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
May 22, 2024
...p/src/test/java/com/datastrato/gravitino/catalog/hadoop/integration/test/HDFSKerberosIT.java
Outdated
Show resolved
Hide resolved
|
@jerryshao |
jerryshao
reviewed
May 22, 2024
| () -> { | ||
| try { | ||
| FileSystem fs = FileSystem.get(conf); | ||
| Path path = new Path("/"); |
There was a problem hiding this comment.
You need to create a file and check the file owner to see if it is expected.
If kerberos is enabled, the user should be "cli" from my understanding.
jerryshao
reviewed
May 22, 2024
| .withHostName("gravitino-ci-kerberos-hive") | ||
| .withEnvVars( | ||
| ImmutableMap.<String, String>builder() | ||
| .put("HADOOP_USER_NAME", "datastrato") |
There was a problem hiding this comment.
I don't think it is needed, you can remove and take a try.
jerryshao
previously approved these changes
May 22, 2024
|
Please fix the style issues. |
done |
jerryshao
approved these changes
May 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
…uster (#3435) ### What changes were proposed in this pull request? Add test cases to test Kerberos authentication for the HDFS cluster. ### Why are the changes needed? To make code more robust. Fix: #3432 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? test cases.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…DFS cluster (apache#3435) ### What changes were proposed in this pull request? Add test cases to test Kerberos authentication for the HDFS cluster. ### Why are the changes needed? To make code more robust. Fix: apache#3432 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add test cases to test Kerberos authentication for the HDFS cluster.
Why are the changes needed?
To make code more robust.
Fix: #3432
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
test cases.