Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3561] improvement(client-python): Fix redefined-builtin Pylint rule for client-python #3562

Merged
merged 4 commits into from
May 27, 2024

Conversation

noidname01
Copy link
Collaborator

What changes were proposed in this pull request?

  • Replace varaible names type and property, which is Python functions and keywords, with more readable and custom variable names

Why are the changes needed?

Fix: #3561

Does this PR introduce any user-facing change?

No

How was this patch tested?

./gradlew clients:client-python:test

Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noidname01 for your contribution.

@jerryshao jerryshao merged commit 6cc6602 into apache:main May 27, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 27, 2024
… for client-python (#3562)

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: #3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…t rule for client-python (apache#3562)

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: apache#3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Fix redefined-builtin Pylint rule for client-python
2 participants