Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4351] [improvement] UI: Switch catalog properties from immutable to mutable #4379

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 5, 2024

What changes were proposed in this pull request?

switch catalog properties value input disable to enable
hive catalog before:
Pasted Graphic
hive catalog after:
Pasted Graphic 1

Iceberg catalog before:
Pasted Graphic 2
iceberg catalog after:
Pasted Graphic 3

pg catalog before:
Pasted Graphic 6
pg catalog after:
Pasted Graphic 7

kafka catalog before:
Pasted Graphic 4
kafka catalog after:
Pasted Graphic 5

fileset catalog before:
Pasted Graphic 8
fileset catalog after:
Pasted Graphic 9

Why are the changes needed?

make the change by the PR merged

Fix: #4351

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

manual

… mutable (#4355)

### What changes were proposed in this pull request?
switch catalog properties value input disable to enable
hive catalog before: 
<img width="623" alt="Pasted Graphic"
src="https://github.com/user-attachments/assets/77472113-ddd8-4051-825a-21bbaaf07bdd">
hive catalog after:
<img width="708" alt="Pasted Graphic 1"
src="https://github.com/user-attachments/assets/d08634da-0044-452d-9ded-ff186aae3507">

Iceberg catalog before: 
<img width="623" alt="Pasted Graphic 2"
src="https://github.com/user-attachments/assets/3ecca557-6b2d-42ab-8d0f-115044fe97b3">
iceberg catalog after:
<img width="588" alt="Pasted Graphic 3"
src="https://github.com/user-attachments/assets/5585d55c-4bec-42c3-b496-eaf75dc55e9f">

pg catalog before:
<img width="580" alt="Pasted Graphic 6"
src="https://github.com/user-attachments/assets/334abb54-ad33-42b5-9d96-6f3d7fdded19">
pg catalog after:
<img width="594" alt="Pasted Graphic 7"
src="https://github.com/user-attachments/assets/4aca0e85-8ba2-4bbe-a19b-58c52685ae42">


kafka catalog before: 
<img width="605" alt="Pasted Graphic 4"
src="https://github.com/user-attachments/assets/37f1938d-90df-45ff-81bf-7081238921db">
kafka catalog after:
<img width="592" alt="Pasted Graphic 5"
src="https://github.com/user-attachments/assets/4dd7e321-dd6a-4e86-8e5d-dae6d601fbf7">

fileset catalog before:
<img width="607" alt="Pasted Graphic 8"
src="https://github.com/user-attachments/assets/1b430711-f494-4b87-89a2-ea9c774c381c">
fileset catalog after:
<img width="618" alt="Pasted Graphic 9"
src="https://github.com/user-attachments/assets/04ce17cb-5eac-4f25-b1e0-e309db2a1103">


### Why are the changes needed?
make the change by the
[PR](#4262) merged

Fix: #4351

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manual
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit e7ca642 into branch-0.6 Aug 6, 2024
26 checks passed
@jerryshao jerryshao deleted the cherry-pick-branch-0.6-1226fb10fae8fb00f254645466943a49c53580d5 branch August 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants