Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4605] Handle NPE in Doris table operation prop append #5125

Merged
merged 4 commits into from
Oct 15, 2024
Merged

[#4605] Handle NPE in Doris table operation prop append #5125

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51ca618
Handle NPE in Doris table operation prop append
avinash-u Oct 13, 2024
8095272
Checking resultMap instead of properties as data is cloned
avinash-u Oct 14, 2024
4e3ff2b
Merge branch 'main' into fix-doris-table-possible-npe
itsaviu Oct 14, 2024
eb4a390
Merge branch 'main' into fix-doris-table-possible-npe
itsaviu Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...oris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ private Map<String, String> appendNecessaryProperties(Map<String, String> proper

// If the backend server is less than DEFAULT_REPLICATION_FACTOR_IN_SERVER_SIDE (3), we need to
// set the property 'replication_num' to 1 explicitly.
if (!properties.containsKey(REPLICATION_FACTOR)) {
if (!resultMap.containsKey(REPLICATION_FACTOR)) {
// Try to check the number of backend servers.
String query = "select count(*) from information_schema.backends where Alive = 'true'";

Expand Down
Loading