[#5162] Add ability to add roles to users and groups in the Gravitino CLI #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
File is not needed
|
@shaofengshi this is walting on the role PR to be merged or you can review the add user or groups to roles part |
# Conflicts: # docs/cli.md
|
@shaofengshi this is now ready to review |
…tOwner.java remove unwanted files
…nerDetails.java delete unwanted file
shaofengshi
reviewed
Nov 13, 2024
shaofengshi
reviewed
Nov 13, 2024
shaofengshi
reviewed
Nov 13, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetOwner.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 13, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/AddRoleToUser.java
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 13, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetOwner.java
Outdated
Show resolved
Hide resolved
|
@shaofengshi ready again for you to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CLI commands and code to add roles to users and groups.
Why are the changes needed?
To support adding and removing roles.
Fix: #5162
Does this PR introduce any user-facing change?
No, but it adds to the CLI.
How was this patch tested?
Compiled and tested locally.