[#5162] Add grant and revoke privileges to the Gravitino CLI. #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
|
@shaofengshi ready to review when the CI is done. |
shaofengshi
reviewed
Dec 6, 2024
shaofengshi
reviewed
Dec 6, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RevokePrivilegesFromRole.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Dec 6, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/GrantPrivilegesToRole.java
Outdated
Show resolved
Hide resolved
|
Sorry I accidentally closed this. |
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestRoleCommands.java
|
I've changed the command to use the role entity. |
shaofengshi
reviewed
Dec 19, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/RevokePrivilegesFromRole.java
Outdated
Show resolved
Hide resolved
|
Justin, thanks for making the update, the new command style is better for understanding I think. After I merge another PR, now it has a conflict, please resolve so that the merge can be continued. Thank you for the effort! |
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
|
@shaofengshi once CI is done it's ready for review |
shaofengshi
approved these changes
Dec 19, 2024
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…pache#5783) ### What changes were proposed in this pull request? Add grant and revoke privileges to the Gravitino CLI. ### Why are the changes needed? To complete the role commands. Fix: apache#5162 ### Does this PR introduce _any_ user-facing change? No but it adds two more commands. ### How was this patch tested? Tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add grant and revoke privileges to the Gravitino CLI.
Why are the changes needed?
To complete the role commands.
Fix: #5162
Does this PR introduce any user-facing change?
No but it adds two more commands.
How was this patch tested?
Tested locally.