[#5947] fix(auth): It will throw error if we enable authorization and rename catalog #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and rename catalog
jerryshao
reviewed
Dec 23, 2024
| @@ -298,9 +298,19 @@ public static void authorizationPluginRenamePrivileges( | |||
| NameIdentifierUtil.toMetadataObject(NameIdentifier.of(ident.namespace(), newName), type); | |||
| MetadataObjectChange renameObject = | |||
| MetadataObjectChange.rename(oldMetadataObject, newMetadataObject); | |||
|
|
|||
| String metalake; | |||
There was a problem hiding this comment.
I think you can change to use ? : operand to simplify your code.
jerqi
added a commit
to qqqttt123/gravitino
that referenced
this pull request
Dec 23, 2024
…on and rename catalog (apache#5949) Fix the issue of renaming catalogs or metalakes. Fix: apache#5947 No. Add UT.
jerqi
added a commit
to qqqttt123/gravitino
that referenced
this pull request
Dec 23, 2024
…on and rename catalog (apache#5949) Fix the issue of renaming catalogs or metalakes. Fix: apache#5947 No. Add UT.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 23, 2024
…on and rename catalog (apache#5949) ### What changes were proposed in this pull request? Fix the issue of renaming catalogs or metalakes. ### Why are the changes needed? Fix: apache#5947 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…on and rename catalog (apache#5949) ### What changes were proposed in this pull request? Fix the issue of renaming catalogs or metalakes. ### Why are the changes needed? Fix: apache#5947 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the issue of renaming catalogs or metalakes.
Why are the changes needed?
Fix: #5947
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UT.