Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor (docs): Update how-to-use-the-playground.md document #5955

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

unknowntpo
Copy link
Contributor

@unknowntpo unknowntpo commented Dec 23, 2024

What changes were proposed in this pull request?

Revert helm-chart related descriptions in docs/how-to-use-the-playground.md.

Why are the changes needed?

Make documentation match README.md of apache/gravitino-playground .

Does this PR introduce any user-facing change?

Yes, documentation is affacted.

How was this patch tested?

Manually.

@unknowntpo
Copy link
Contributor Author

@xunliu Please have a look.

Comment on lines 54 to 56
```
./playground.sh docker start
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed at a63cd7c.

@xunliu xunliu changed the title docs(docs/how-to-use-the-playground.md): revert helm-chart related do… Minor (docs): Update how-to-use-the-playground.md document Dec 24, 2024
Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @xunliu do you want to take another look?

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unknowntpo Thank you for your contributions.
LGTM

@xunliu xunliu merged commit a58b7f8 into apache:main Dec 24, 2024
23 checks passed
@unknowntpo unknowntpo deleted the docs-revert-how-to-use-the-playground branch December 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants