[#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse #6013
Conversation
� Conflicts: � clients/filesystem-fuse/src/main.rs � Conflicts: � clients/filesystem-fuse/src/filesystem.rs � clients/filesystem-fuse/src/main.rs
diqiu50
changed the title
| 0o700, | ||
| ); | ||
|
|
||
| const FUSE_FS_TYPE: ConfigEntity<&'static str> = ConfigEntity::new( |
There was a problem hiding this comment.
For naming conventions, I'd suggest we remove FUSE_ from the constant names and add DEFAULT_ to all default values for clarity.
There was a problem hiding this comment.
That's config entity. the default value is a member data. so the entity name use default is not good
clients/filesystem-fuse/src/main.rs
Outdated
| use tokio::signal; | ||
|
|
||
| #[tokio::main] | ||
| async fn main() -> fuse3::Result<()> { | ||
| tracing_subscriber::fmt().init(); | ||
| tokio::spawn(async { gvfs_mount("gvfs").await }); | ||
|
|
||
| let config = AppConfig::from_file(Some("conf/gvfs_fuse.toml)")); |
There was a problem hiding this comment.
How can we ensure this relative path is always correct?
There was a problem hiding this comment.
That's not implemented. we need to read config file path from app arguments.
| } | ||
|
|
||
| async fn read_dir(&self, path: &Path) -> Result<Vec<FileStat>> { | ||
| let file_name = path.to_string_lossy().to_string(); |
There was a problem hiding this comment.
path might be something other than a directory?
There was a problem hiding this comment.
That‘s impossible.
Actually, It is impossible to distinguish a file from a directory based on the path alone. If the wrong type is passed, an error will occur later.
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
What changes were proposed in this pull request?
Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal
Why are the changes needed?
Fix: #6012
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually test