[#596] feat(doc): Add doc for Hadoop access #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
jerryshao
reviewed
Oct 26, 2023
docs/gravitino-server-config.md
Outdated
| Currently, Gravitino server use `gravitino` as default Hadoop username, since Gravitino need to access Hadoop(HDFS, YARN etc.) while | ||
| performing certain operations, please make sure that `gravitino` have the necessary permissions for accessing HDFS or | ||
| you can change the value of `HADOOP_USER_NAME` by editing the `gravitino-env.sh` file before starting the Gravitino | ||
| server. |
There was a problem hiding this comment.
I think what you need to write is to explain the limitation of current Gravitino, and describe the workaround solutions to users, and tell users we will add user impersonation support in future.
There was a problem hiding this comment.
I have updated the doc, how about the current describtion?
FANNG1
reviewed
Oct 26, 2023
|
|
||
| Gravitino server also supports setting up runtime environment variables by editing the `gravitino-env.sh` file, which is located in the `conf` directory. | ||
|
|
||
| ### How to access Hadoop |
There was a problem hiding this comment.
could you add a link to How to access Hadoop in Iceberg-rest-service.md?
There was a problem hiding this comment.
@mchades please address this comment.
There was a problem hiding this comment.
Solved. Please review again, thanks.
|
@mchades Can you please change the PR title and description to reflect what you changed here? |
mchades
changed the title
jerryshao
changed the title
jerryshao
approved these changes
Oct 26, 2023
jerryshao
approved these changes
Oct 26, 2023
jerryshao
pushed a commit
that referenced
this pull request
Oct 26, 2023
### What changes were proposed in this pull request? - add `How to access Hadoop` - add runtime environment set up doc - Revised some content ### Why are the changes needed? The workaround of cannot specify the Hadoop username ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local test
jerryshao
pushed a commit
that referenced
this pull request
Oct 26, 2023
### What changes were proposed in this pull request? - add `How to access Hadoop` - add runtime environment set up doc - Revised some content ### Why are the changes needed? The workaround of cannot specify the Hadoop username ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How to access HadoopWhy are the changes needed?
The workaround of cannot specify the Hadoop username
Does this PR introduce any user-facing change?
no
How was this patch tested?
local test