Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1885. Fix bug in checkAcls in OzoneManager. #1199

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 requested a review from arp7 July 31, 2019 17:36
@bharatviswa504 bharatviswa504 self-assigned this Jul 31, 2019
@bharatviswa504 bharatviswa504 requested a review from xiaoyuyao July 31, 2019 17:38
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 79 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 602 trunk passed
+1 compile 351 trunk passed
+1 checkstyle 69 trunk passed
+1 mvnsite 1 trunk passed
+1 shadedclient 897 branch has no errors when building and testing our client artifacts.
+1 javadoc 155 trunk passed
0 spotbugs 413 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 607 trunk passed
_ Patch Compile Tests _
+1 mvninstall 526 the patch passed
+1 compile 359 the patch passed
+1 javac 359 the patch passed
+1 checkstyle 72 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 708 patch has no errors when building and testing our client artifacts.
+1 javadoc 154 the patch passed
+1 findbugs 644 the patch passed
_ Other Tests _
-1 unit 353 hadoop-hdds in the patch failed.
-1 unit 1903 hadoop-ozone in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
7689
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1199/1/artifact/out/Dockerfile
GITHUB PR #1199
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f8d356895e42 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b008072
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1199/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1199/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1199/1/testReport/
Max. process+thread count 4282 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1199/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

Test failures and check styles are not related to this patch.
Thank You @arp7 for the review. I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit c1f7440 into apache:trunk Aug 1, 2019
@bharatviswa504 bharatviswa504 deleted the HDDS-1885 branch August 1, 2019 02:13
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants